os/bluestore: simplified allocator interfaces to single apis #12355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chhabaramesh
force-pushed
the
bit_alloc_mempool
branch
2 times, most recently
from
8cbd94f
to
365c7ab
Compare
chhabaramesh
force-pushed
the
bit_alloc_mempool
branch
3 times, most recently
from
8a1f5cf
to
822fc22
Compare
chhabaramesh
changed the title
|
@liewegas please have a look at it. While I am doing more testing on it individually, maybe we can also include this in normal runs ? |
|
@liewegas , this one passes the ceph_objectstore test. Please review and merge. |
liewegas
reviewed
Dec 12, 2016
|
|
||
| ExtentList block_list = ExtentList(extents, m_block_size, max_alloc_size); | ||
|
|
||
| while (need_blks > 0) { | ||
| int64_t count = 0; | ||
| count = m_bit_alloc->alloc_blocks_res( | ||
| (max_blks && need_blks > max_blks) ? max_blks : need_blks, hint, &start_blk); | ||
| count = m_bit_alloc->alloc_blocks_res(cont_blks, hint, &start_blk); |
There was a problem hiding this comment.
This looks really inefficient.. if I'm reading this right, you're calling into alloc_blocks_res for every alloc_unit (min_alloc_size). Is that right?
There was a problem hiding this comment.
@liewegas , yes you are right, I keep forgetting that min_alloc_size could change and we may fall in to this case more often than I think.
I am modifying the existing alloc_extent code to search the free extents when min_alloc_size is not equal to bit in the bitmap.
Will update you soon.
chhabaramesh
force-pushed
the
bit_alloc_mempool
branch
3 times, most recently
from
17da20f
to
2476c87
Compare
…lloc_size Signed-off-by: Ramesh Chander <Ramesh.Chander@sandisk.com>
Signed-off-by: Ramesh Chander <Ramesh.Chander@sandisk.com>
Signed-off-by: Ramesh Chander <Ramesh.Chander@sandisk.com>
Signed-off-by: Ramesh Chander <Ramesh.Chander@sandisk.com>
Signed-off-by: Ramesh Chander <Ramesh.Chander@sandisk.com>
Signed-off-by: Ramesh Chander <Ramesh.Chander@sandisk.com>
Signed-off-by: Ramesh Chander <Ramesh.Chander@sandisk.com> zone block offset related test case Signed-off-by: Ramesh Chander <Ramesh.Chander@sandisk.com>
chhabaramesh
force-pushed
the
bit_alloc_mempool
branch
from
2476c87
to
f1e9aee
Compare
chhabaramesh
changed the title
chhabaramesh
force-pushed
the
bit_alloc_mempool
branch
from
d3fa7dd
to
b7b92ba
Compare
Signed-off-by: Ramesh Chander <Ramesh.Chander@sandisk.com>
chhabaramesh
force-pushed
the
bit_alloc_mempool
branch
from
b7b92ba
to
9ce95bb
Compare
liewegas
approved these changes
Dec 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ramesh Chander Ramesh.Chander@sandisk.com