cmake: detect keyutils if WITH_LIBCEPHFS OR WITH_RBD #12359
Conversation
* find_package(keyutils REQUIRED) if (WITH_LIBCEPHFS OR WITH_RBD) prior to this change, we detect keyutils if the building platform is not FreeBSD, we should instead check the WITH_* options, and let the maintainer to decided what is the best for his/her platform, and error out if the building host cannot fulfill the requirement to build the asserts. * build krbd.cc if (WITH_RBD) Signed-off-by: Kefu Chai <kchai@redhat.com>
* simplify the link dependencies.
* s/keyutils/${KEYUTILS_LIBRARIES}/
Signed-off-by: Kefu Chai <kchai@redhat.com>
|
@wjwithagen does this change make sense to you? it reverts part of c7c07da |
|
@tchaikov @bassamtabbara |
|
@wjwithagen okay, since keyutils is still required by rbd, let's worry about it once you decide to look at it. |
| if(LINUX) | ||
| add_library(krbd_objs OBJECT krbd.cc) | ||
| endif() | ||
|
|
||
| if(${WITH_RBD}) |
There was a problem hiding this comment.
should this be if (WITH_RBD)
There was a problem hiding this comment.
@bassamtabbara
Yup, that is the normal invocation in the project, yours would work also in this specific case but still without ${} is preferred.
But if you want to know, loks up variable in the cmake manual
There was a problem hiding this comment.
thanks, will change it next time when i happen to be changing this part.
No description provided.