tests: remove TestPGLog EXPECT_DEATH tests #12361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
As per Sam Just advice, remove the EXPECT_DEATH tests to avoid intermittent hang because they do not play well with threads. Fixes: http://tracker.ceph.com/issues/18030 Signed-off-by: Loic Dachary <loic@dachary.org>
|
@tchaikov I'm seing at least one test_pglog hang a day when reviewing the "failed jenkins jobs":https://jenkins.ceph.com/job/ceph-pull-requests/rssFailed . If I don't see any a week after this is merged, it will be a good indication that the root cause is indeed related to threads/expect_death issues. |
tchaikov
approved these changes
Dec 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Sam Just advice, remove the EXPECT_DEATH tests to avoid
intermittent hang because they do not play well with threads.
Fixes: http://tracker.ceph.com/issues/18030
Signed-off-by: Loic Dachary loic@dachary.org