qa/workunits/rbd: use more recent qemu-iotests that support Xenial #12371
Conversation
| cd qemu | ||
| git checkout 2528043f1f299e0e88cb026f1ca7c40bbb4e1f80 | ||
| if `lsb_release -da | grep -i xenial > /dev/null`; then |
There was a problem hiding this comment.
@dillaman You could use grep -q option to avoid /dev/null redirect. Or just if [ "$(lsb_release -sc)" = xenial ].
Also, do you expect this to work for post xenial releases? Then might be "$(lsb_release -is)" = Ubuntu -a "$(lsb_release -rs)" '>' 16?
There was a problem hiding this comment.
I've just grown used to the fact that this test needs to be updated w/ each major OS release
| git checkout v2.3.0 | ||
| else | ||
| # use v2.2.0-rc3 (last released version that handles all the tests | ||
| git checkout 2528043f1f299e0e88cb026f1ca7c40bbb4e1f80 |
There was a problem hiding this comment.
just wondering, can't we use v2.3.0 for all cases?
There was a problem hiding this comment.
I tried that first -- the newer harness uses CLI options not available in the older versions.
qa/workunits/rbd: use more recent qemu-iotests that support Xenial #12371 Conflicts: qa/workunits/rbd/qemu-iotests.sh
|
@dillaman Could you please rebase |
|
@trociny rebased |
| cd qemu | ||
| git checkout 2528043f1f299e0e88cb026f1ca7c40bbb4e1f80 | ||
| if `lsb_release -da | grep -iq xenial`; then |
There was a problem hiding this comment.
@dillaman Sorry, missed this in the previous review, actually no need to backquote here, i.e. I think it should be:
if lsb_release -da | grep -iq xenial; then
In your case it executes it in subshell and if it happened that it returned some output this output would be used as a command for if.
Fixes: http://tracker.ceph.com/issues/18149 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
|
@trociny updated |
Fixes: http://tracker.ceph.com/issues/18149
Signed-off-by: Jason Dillaman dillaman@redhat.com