Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Don't write to a poolid that this test might not have created #12378

Merged
merged 1 commit into from Dec 12, 2016

Conversation

dzafman
Copy link
Contributor

@dzafman dzafman commented Dec 8, 2016

No description provided.

Signed-off-by: David Zafman <dzafman@redhat.com>
@dzafman dzafman added the tests label Dec 8, 2016
@dzafman dzafman added this to the kraken milestone Dec 8, 2016
@dzafman
Copy link
Contributor Author

dzafman commented Dec 8, 2016

Waiting for wip-zafman-testing2 to build so I can run the modified test to make sure it passes.

@tchaikov
Copy link
Contributor

tchaikov commented Dec 8, 2016

@dzafman, yes, the pool might not have been created yet, but Objecter::_op_submit() will retry if the pool is DNE. and it's fine to issue write op to the pool being created, i think. what issue did you run into?

@dzafman
Copy link
Contributor Author

dzafman commented Dec 8, 2016

@tchaikov Between the 2 pool creates another test created a pool, so that the second pool is NOT poolid (first pool) + 1. That poolid belongs to another tests pool and the write createe object "foo" in the other test's pool. The other test was testing enumerate and the extra object caused the test to fail.

@dzafman dzafman merged commit 836d896 into ceph:master Dec 12, 2016
@dzafman dzafman deleted the wip-18139 branch December 12, 2016 15:56
@tchaikov
Copy link
Contributor

@dzafman, i see. so this test is a little bit fragile that we could be writing to another pool created by another test but in the same cluster. in that case, we fail to test the racing. but we cannot use rados_ioctx_create(), because the pool is not yet created when we try to look up the pool by its name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants