rbd: --max_part and --nbds_max options for nbd map #12379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trociny , as we talked, I create a new pr for rbd nbd map, please take a look. |
trociny
changed the title
trociny
reviewed
Dec 8, 2016
| @@ -1102,6 +1103,8 @@ | |||
| --read-only mount read-only | |||
| --exclusive forbid other clients write | |||
| --device arg specify nbd device | |||
| --nbds_max arg Override for module param nbds_max | |||
| --max_part arg Override for module param max_part | |||
|
|
|||
There was a problem hiding this comment.
The description for other options starts in lower case, please, be consistent.
Also it looks it would look more consistent without "for": "override module param nbds_max"...
There was a problem hiding this comment.
@trociny I agree. I have modified, please take a look. Thanks!
trociny
reviewed
Dec 8, 2016
| ("device", po::value<std::string>(), "specify nbd device"); | ||
| ("device", po::value<std::string>(), "specify nbd device") | ||
| ("nbds_max", po::value<std::string>(), "Override for module param nbds_max") | ||
| ("max_part", po::value<std::string>(), "Override for module param max_part"); |
There was a problem hiding this comment.
@liupan1111 It looks you forgot to update here too
There was a problem hiding this comment.
@trociny yeah... modified. Sorry for the trouble.
Fixes: http://tracker.ceph.com/issues/18186 Signed-off-by: Pan Liu <pan.liu@istuary.com>
trociny
pushed a commit
that referenced
this pull request
Dec 8, 2016
rbd: --max_part and --nbds_max options for nbd map #12379
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ep consistent with rbd_nbd map
Fixes: http://tracker.ceph.com/issues/18186
Signed-off-by: Pan Liu pan.liu@istuary.com