erasure-code: synchronize with upstream gf-complete #12382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: http://tracker.ceph.com/issues/18092 Signed-off-by: Loic Dachary <loic@dachary.org>
ghost
added
|
@bassamtabbara the make check passed and the submodule was updated to a commit including the fix, meaning it does not break anything. There is no test showing the problem unfortunately. Although we could try to simulate the absence of the PCLMUL flag to verify tests pass as they should, making it so it would fail with an illegal instruction would be challenging and too fragile to be maintainable. |
bassam
approved these changes
Dec 8, 2016
|
high five! |
liewegas
approved these changes
Dec 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/18092
Signed-off-by: Loic Dachary loic@dachary.org