osd: default osd_scrub_during_recovery=false #12402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a more friendly behavior. Tell users in the release notes how to get the old behavior. Signed-off-by: Sage Weil <sage@redhat.com>
|
Hmm, note that the scrub backoff behavior is incomplete; we only look for recovery on the primary, but not on the replicas. Nevertheless, I think this is the right step forward. |
|
Seems ok to me. |
athanatos
approved these changes
Dec 9, 2016
|
I don't think this is well tested though, it should certainly be tested first. |
|
I'll add it to wip-sam-testing later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more friendly behavior. Tell users in the release notes how to
get the old behavior.
Signed-off-by: Sage Weil sage@redhat.com