jewel: build/ops: install-deps.sh based on /etc/os-release #12405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jan--f Please get rid of the merge commit. |
|
@dachary IIRC there is nothing in the integration test suites that exercises install-deps.sh, correct? |
jan--f
force-pushed
the
wip-18199-jewel
branch
from
9e0ac66
to
362b7af
Compare
|
@jan--f Please rebase to the latest jewel (i.e. something like |
|
The tox test failure is benign. |
jan--f
force-pushed
the
wip-18199-jewel
branch
from
362b7af
to
a3e9148
Compare
This avoids initial distribution detection (before lsb_release is available) based on the presence of a specific package manager. This caused an issue with openSUSE Tumbleweed before since both zypper and apt-get are available. Signed-off-by: Jan Fajerski <jfajerski@suse.com> (cherry picked from commit 85a370e)
85a370e introduced the DISTRO variable whose value was obtained by parsing /etc/os-release like this: DISTRO=$(grep "^ID=" /etc/os-release | sed "s/ID=//") This unfortunately picks up the double-quotes, so on a CentOS system DISTRO will be equal to '"centos"'. Signed-off-by: Nathan Cutler <ncutler@suse.com> (cherry picked from commit fd37e87)
jan--f
force-pushed
the
wip-18199-jewel
branch
from
a3e9148
to
240431b
Compare
|
Jenkins, retest this please |
|
@jan--f Please cherry-pick 266f4d4 into this PR. When you do please remind me to:
|
Avoids this error on SLES systems: > ./install-deps.sh sles is unknown, dependencies will have to be installed manually. Signed-off-by: Nitin A Kamble <Nitin.Kamble@Teradata.com> (cherry picked from commit 266f4d4) Conflict in install-deps.sh due to indentation. Trivial resolution.
Signed-off-by: Jan Fajerski <jfajerski@suse.com>
|
Jenkins, retest this please |
|
@jan--f Excellent, thanks! |
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/18199
http://tracker.ceph.com/issues/18466