Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: msgr: don't truncate message sequence to 32-bits #12416

Merged
merged 1 commit into from Jan 31, 2017

Conversation

smithfarm
Copy link
Contributor

@smithfarm smithfarm commented Dec 9, 2016

Message sequence is 64-bits number, but the upper 32-bits get lost
when setting/getting message sequence. This causes messenger to
malfunction after receiving 1^32 messages

Fixes: http://tracker.ceph.com/issues/16122
Signed-off-by: Yan, Zheng <zyan@redhat.com>
(cherry picked from commit d52832d)
@smithfarm smithfarm added this to the jewel milestone Dec 9, 2016
@smithfarm smithfarm self-assigned this Dec 9, 2016
@ghost ghost changed the base branch from jewel-next to jewel December 21, 2016 23:23
@smithfarm smithfarm changed the title msg: don't truncate message sequence to 32-bits jewel: msg: don't truncate message sequence to 32-bits Jan 9, 2017
@smithfarm
Copy link
Contributor Author

@tchaikov This passed a rados suite at http://tracker.ceph.com/issues/17851#note-45 with some (few, unrelated) failures as well as an fs suite at http://tracker.ceph.com/issues/17851#note-49

OK to merge?

@tchaikov
Copy link
Contributor

retest this please.

Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@smithfarm smithfarm merged commit 586f4ea into ceph:jewel Jan 31, 2017
@smithfarm smithfarm deleted the wip-18219-jewel branch January 31, 2017 13:54
@smithfarm smithfarm changed the title jewel: msg: don't truncate message sequence to 32-bits jewel: msgr: don't truncate message sequence to 32-bits Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants