Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jewel: rgw sends omap_getvals with (u64)-1 limit #12419

Merged
merged 2 commits into from Feb 1, 2017
Merged

jewel: rgw sends omap_getvals with (u64)-1 limit #12419

merged 2 commits into from Feb 1, 2017

Conversation

smithfarm
Copy link
Contributor

@smithfarm smithfarm commented Dec 9, 2016 •
edited

liewegas and others added 2 commits December 9, 2016 15:21
@liewegas @smithfarm
rgw/rgw_rados: do not omap_getvals with (u64)-1 max
df9d929 
Fixes: http://tracker.ceph.com/issues/17985

This will make the OSD fall over if the object is big
and the OSD doesn't impose it's own fail-safe limit.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 7cd123e)
@yehudasa @smithfarm
rgw: omap_get_all() fixes
8b10d3b 
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
(cherry picked from commit 99e866f)
@smithfarm smithfarm added this to the jewel milestone Dec 9, 2016
@smithfarm smithfarm self-assigned this Dec 9, 2016
@ghost ghost changed the base branch from jewel-next to jewel December 21, 2016 23:23
@smithfarm smithfarm merged commit bf1e63b into ceph:jewel Feb 1, 2017
@smithfarm smithfarm deleted the wip-18217-jewel branch February 1, 2017 21:34
@smithfarm
Copy link
Contributor Author

This passed RGW runs at http://tracker.ceph.com/issues/17851#note-50 and http://tracker.ceph.com/issues/17851#note-58

@smithfarm
Copy link
Contributor Author 

(11:46:45 AM) smithfarm: owasserm: thanks. For jewel integration rgw, then, what it comes down to is verifying that these 6 valgrind failures are all libtcmalloc-related: http://pulpito.front.sepia.ceph.com/smithfarm-2017-01-31_12:35:14-rgw-wip-jewel-backports-distro-basic-smithi/
(11:46:58 AM) smithfarm: owasserm: I will do that now
(11:47:05 AM) owasserm: smithfarm, thanks
(11:47:33 AM) smithfarm: owasserm: and assuming they are tcmalloc related, you said I can directly merge all the rgw PRs? Or do you want me to ask you for review in the PRs first?
(11:47:53 AM) owasserm: smithfarm, yes you can merge them
(11:48:19 AM) smithfarm: ok, will merge and do at least one or two more rgw runs before passing 10.2.6 to QE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smithfarm smithfarm

Labels
bug-fix rgw
Projects
None yet
Milestone
jewel
3 participants
@smithfarm @liewegas @yehudasa