mds: release pool allocator memory after exceeding size limit #12443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 12, 2016 12:02
Usually we like keeping the memory in our pools, but in circumstances where we have violated our self-imposed inode count cap, we should shrink our usage of system memory afterwards. Fixes: http://tracker.ceph.com/issues/18225 Signed-off-by: John Spray <john.spray@redhat.com>
...now that it's used more than once place, copying around the fraction was bad. Signed-off-by: John Spray <john.spray@redhat.com>
gregsfortytwo
approved these changes
Dec 12, 2016
|
Hmm, we should probably add a quick check for this functioning somewhere though. Maybe it can ride along on some of the fill-the-cache teuthology tests? |
|
Hi guys, I can help to merge this commit into our internal ceph code base to have a quick check since I threw the question in the email few days ago and we have ready-made cluster at hand. What do you think? |
|
@david-z I've merged this since it passes our regression tests, but if you could also test that it really behaves as expected that would be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/18225