Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgw: use explicit flag to cancel RGWCoroutinesManager::run() #12452

Merged
merged 1 commit into from Dec 14, 2016
Merged

rgw: use explicit flag to cancel RGWCoroutinesManager::run() #12452

merged 1 commit into from Dec 14, 2016

Commits on Dec 12, 2016

  1. rgw: use explicit flag to cancel RGWCoroutinesManager::run() 

    RGWCoroutinesManager::run() was setting ret = -ECANCELED to break out of
the loop when it sees going_down. coroutines that failed with -ECANCELED
were confusing this logic and leading to coroutine deadlock assertions
below. when we hit the going_down case, set a 'canceled' flag, and check
that flag when deciding whether to break out of the loop

Fixes: http://tracker.ceph.com/issues/17465

Signed-off-by: Casey Bodley <cbodley@redhat.com>
    @cbodley
    cbodley committed Dec 12, 2016
    Copy the full SHA
    73cd8df View commit details
    Browse the repository at this point in the history