osd: enhance logging for osd network error #12458
Conversation
|
@tchaikov please take a look, It's useful when I do some network crash test to osd. |
| @@ -7134,21 +7134,21 @@ void OSD::_committed_osd_maps(epoch_t first, epoch_t last, MOSDMap *m) | |||
| if (r != 0) { | |||
| do_shutdown = true; // FIXME: do_restart? | |||
| network_error = true; | |||
| dout(0) << __func__ << " marked down: rebind failed" << dendl; | |||
| dout(0) << __func__ << " marked down: rebind cluster_messager failed" << dendl; | |||
There was a problem hiding this comment.
need to wrap line at 80 chars.
|
lgtm, just need to wrap the line. |
liuchang0812
force-pushed
the
add-more-log-for-network-error
branch
2 times, most recently
from
8a2604a
to
e5233fa
Compare
|
@tchaikov it's done. thanks for your suggestion |
| @@ -7134,21 +7134,24 @@ void OSD::_committed_osd_maps(epoch_t first, epoch_t last, MOSDMap *m) | |||
| if (r != 0) { | |||
| do_shutdown = true; // FIXME: do_restart? | |||
| network_error = true; | |||
| dout(0) << __func__ << " marked down: rebind failed" << dendl; | |||
| dout(0) << __func__ | |||
| << " marked down: rebind cluster_messager failed" << dendl; | |||
There was a problem hiding this comment.
there is a typo, should be cluster_messenger
There was a problem hiding this comment.
thanks, my bad. I have fixed this typo.
liuchang0812
force-pushed
the
add-more-log-for-network-error
branch
from
e5233fa
to
048fa82
Compare
|
@tchaikov @hjwsm1989 it's done. |
|
@tchaikov hi, tchaikov, need your approval 😺 |
|
retest this please |
|
On behalf of @tchaikov (since he is on vacation). |
|
@xiexingguo thanks 👍 |
| @@ -7134,21 +7134,24 @@ void OSD::_committed_osd_maps(epoch_t first, epoch_t last, MOSDMap *m) | |||
| if (r != 0) { | |||
| do_shutdown = true; // FIXME: do_restart? | |||
| network_error = true; | |||
| dout(0) << __func__ << " marked down: rebind failed" << dendl; | |||
| dout(0) << __func__ | |||
There was a problem hiding this comment.
It looks better if you do all the changes the same way and seems the preferred option is to be << aligned here:
dout(0) << __func__ << " marked down:"
<< " marked down: rebind cluster_messenger failed" << dendl;
There was a problem hiding this comment.
yes, it's better. I have updated this code. thanks 😄
liuchang0812
force-pushed
the
add-more-log-for-network-error
branch
2 times, most recently
from
b96dcb5
to
6656892
Compare
Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
liuchang0812
force-pushed
the
add-more-log-for-network-error
branch
from
6656892
to
7ceadba
Compare
xiexingguo
changed the title
Signed-off-by: liuchang0812 liuchang0812@gmail.com