librbd: remove consistency group rbd cli and API support #12475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithfarm
reviewed
Dec 13, 2016
| std::string name; | ||
| int64_t pool; | ||
| } group_spec_t; | ||
|
|
||
| // Consistency groups functions | ||
| int group_create(librados::IoCtx& io_ctx, const char *imgname); | ||
| int group_remove(librados::IoCtx& io_ctx, const char *group_name); |
There was a problem hiding this comment.
Why are you retaining the function declarations when the corresponding definitions have been dropped?
There was a problem hiding this comment.
@smithfarm I am mostly concerned about ensuring the API and cli isn't there -- leaving unused functions is less of a priority to me.
|
Please hold off on merging this into the kraken branch until we're ready. Thanks! |
liewegas
changed the title
|
@dillaman need to update test/cli/rbd/help.t |
Fixes: http://tracker.ceph.com/issues/18231 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
dillaman
force-pushed
the
wip-18231-kraken
branch
from
0874398
to
15a5ace
Compare
liewegas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/18231
Signed-off-by: Jason Dillaman dillaman@redhat.com