CMakeLists: add vstart-base target #12476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
requested changes
Dec 14, 2016
| @@ -934,20 +934,25 @@ configure_file( | |||
| add_subdirectory(brag) | |||
|
|
|||
| # Everything you need to spin up a cluster with vstart.sh | |||
| add_custom_target(vstart DEPENDS | |||
| add_custom_target(vstart-base DEPENDS | |||
There was a problem hiding this comment.
it's vstart-base not vstart-rados?
and ceph cli requires cython_rados, so maybe we can move cython_rados into vstart-rados (or vstart-base) ?
No mds or radosgw. Add rados CLI. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-vstart-rados
branch
from
2b6e948
to
3faf8b8
Compare
liewegas
changed the title
|
updated! |
tchaikov
approved these changes
Dec 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No mds or radosgw. Add rados CLI.
Signed-off-by: Sage Weil sage@redhat.com