qa/workunits/rbd: fix #12511
Merged
qa/workunits/rbd: fix #12511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sage Weil <sage@redhat.com>
Root of git checkout Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-workunits
branch
from
e39935d
to
fc3f25e
Compare
liewegas
force-pushed
the
wip-workunits
branch
from
fc3f25e
to
670a517
Compare
trociny
reviewed
Dec 15, 2016
| else | ||
| . $(dirname $0)/rbd_mirror_helpers.sh | ||
| fi | ||
| . ./rbd_mirror_helpers.sh |
There was a problem hiding this comment.
@liewegas I suppose it wont work when running this locally from cmake build dir, i.e.:
../qa/workunits/rbd/rbd_mirror.sh
There was a problem hiding this comment.
oh right. i'll do dirname unconditionally
liewegas
force-pushed
the
wip-workunits
branch
from
670a517
to
93620d0
Compare
liewegas
force-pushed
the
wip-workunits
branch
from
93620d0
to
9409e85
Compare
Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-workunits
branch
from
9409e85
to
cf29477
Compare
|
@liewegas Are we going to try to backport these changes to jewel? |
|
@smithfarm I think this will need to get backported to all active "testing" branches (including possibly some EoLed releases due to upgrade tests). |
|
Yep! I was just going to make sure they passed first. But either way
we'll backport these (+ fixes) so go ahead!
|
|
jewel and hammer
|
|
OK, created the master and backport tracker issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/18271