qa/tasks/ceph_deploy: use dev option instead of dev-commit #12514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vasu Kulkarni <vasu@redhat.com>
|
@vasukulkarni What is this for? I seem to remember the dev-commit being needed for a reason (upgrade tests maybe?) but I can't remember. |
|
@liewegas sorry i should have added tracker, http://tracker.ceph.com/issues/18253 , This is for ceph-deploy suite to work with shaman and will not affect upgrade tests, Assigning to @alfredodeza |
liewegas
changed the title
liewegas
approved these changes
Dec 16, 2016
|
note that before these options where mutually exclusive. Now they aren't, because with the new system, when you specify a SHA1, you must point to the branch too because they are built tied to branches. It isn't possible to specify just a SHA1 (which this PR addresses) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vasu Kulkarni vasu@redhat.com