Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/CMakeLists.txt: disable -Werror on rocksdb #12560

Merged
merged 1 commit into from Jan 9, 2017
Merged

src/CMakeLists.txt: disable -Werror on rocksdb #12560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/CMakeLists.txt
View file
Open in desktop
Expand Up @@ -700,6 +700,10 @@ endif(WITH_CCACHE AND CCACHE_FOUND)
list(APPEND ROCKSDB_CMAKE_ARGS -DCMAKE_AR=${CMAKE_AR})
list(APPEND ROCKSDB_CMAKE_ARGS -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE})

if (CMAKE_CXX_COMPILER_ID STREQUAL Clang)
list(APPEND ROCKSDB_CMAKE_ARGS -DFAIL_ON_WARNINGS=OFF)
Copy link
Contributor

@tchaikov tchaikov Jan 9, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, the patch silencing the warning is posted at facebook/rocksdb#1757.

we should revert this change once patch lands on the upstream. and our rocksdb is sync'ed with upstream.

endif()

# we use an external project and copy the sources to bin directory to ensure
# that object files are built outside of the source tree.
include(ExternalProject)
Expand Down