osd: Fix map gaps again (bug 15943) #12571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_snaps Signed-off-by: Samuel Just <sjust@redhat.com>
Also, make map gaps more likely. Signed-off-by: Samuel Just <sjust@redhat.com>
5798fb3 actually made 15943 worse by always creating an out-of-date cached_removed_snaps value after a map gap rather than only in the case where the the first map after the gap did not remove any snapshots. Introduced: 5798fb3 Fixes: http://tracker.ceph.com/issues/15943 Signed-off-by: Samuel Just <sjust@redhat.com>
|
http://pulpito.ceph.com/samuelj-2016-12-18_07:44:35-rados-wip-sam-testing---basic-smithi/ Failures seem to be unrelated. Annoyingly, http://pulpito.ceph.com/samuelj-2016-12-18_07:42:48-rados-wip-15943-no-fix---basic-smithi did not turn up any failures when run with the added assert, but no fix. I think we should still merge it, but I'd like to get a better test written. |
liewegas
approved these changes
Dec 19, 2016
liewegas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.