osd: correct epoch setting of osd boot msg #12623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use get_osdmap_epoch() maybe better than superblock's current_epoch, because _send_boot() might happen when committing new osdmap, superblock.current_epoch prior to osdmap.epoch, _committed_osd_map() may modify some osd metadata thereafter, thus, break the consistency between epoch and metadata in boot msg. Signed-off-by: Mingxin Liu <mingxin@xsky.com>
|
@tchaikov pls review, thanks! |
|
I think _send_boot happens under osd_lock? |
|
@liewegas yeah, but superblock.current_epoch set at handle_osd_map(), then committing osdmap, finally call _commiitted_osd_map and consume map, it will change some metadata, like cluster addr. _send_boot may happen at the interval, sometimes committing into store may laggy if disk busy, and osd_lock racing, expand that time window |
liewegas
approved these changes
Feb 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use get_osdmap_epoch() maybe better than superblock's current_epoch, because
_send_boot() might happen when committing new osdmap, superblock.current_epoch
prior to osdmap.epoch, _committed_osd_map() may modify some osd metadata thereafter,
thus, break the consistency between epoch and metadata in boot msg.
Signed-off-by: Mingxin Liu mingxin@xsky.com