Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/suites: switch from centos 7.2 to 7.x #12632

Merged
merged 4 commits into from Dec 22, 2016
Merged

Conversation

liewegas
Copy link
Member

In general we don't care with point release we get.

Add a centos_7.3.yaml for cases where we do.

No need to be picky about the point release here.

Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas liewegas added the tests label Dec 22, 2016
@liewegas liewegas added this to the kraken milestone Dec 22, 2016
Copy link
Contributor

@yuriw yuriw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 do we need it in master as well?

@liewegas
Copy link
Member Author

Yes--I'll merge kraken back into master.

Signed-off-by: Sage Weil <sage@redhat.com>
@yuriw yuriw merged commit 779ce4c into ceph:kraken Dec 22, 2016
smithfarm added a commit to SUSE/ceph that referenced this pull request Jan 3, 2017
Modeled after ceph#12632

Fixes: http://tracker.ceph.com/issues/18405
Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
Copy link
Contributor

This new "centos.yaml" which specifies os_type: centos but does not specify os_version seems to cause trouble when passing e.g. "qa/distros/all/ubuntu_14.04.yaml" as an argument to teuthology-suite. Since the test yaml does not specify os_version, it gets picked up from the yaml provided on the command line, yielding test descriptions that say:

os_type: centos
os_version: 14.04

@yuriw
Copy link
Contributor

yuriw commented Jan 3, 2017 via email

@smithfarm
Copy link
Contributor

I guess the problem referred to above could be considered a bug in teuthology, so I opened http://tracker.ceph.com/issues/18420

@vasukulkarni
Copy link
Contributor

@smithfarm what you are doing looks like user error, the overrides you are using doesn't apply properly for this suite, there is nothing the cli can do here.

@smithfarm
Copy link
Contributor

@vasukulkarni The fact is that the following two yaml fragments currently produce "centos 14.04":

Fragment 1 (in suite yaml)

os_type: centos

Fragment 2 (on command line)

os_type: ubuntu
os_version: "14.04"

You can call this user error if you like, but teuthology doesn't have to treat it this way.

@vasukulkarni
Copy link
Contributor

@smithfarm I understand, what I am trying to say is the version overrides doesn't apply due to only one distro file here, one could add ubuntu distro and use filter option just like we do for other suites.

@vasukulkarni
Copy link
Contributor

@smithfarm on the other note, you should use --distro and --distro-version instead from the cli for os overrides

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants