hammer: tests: Workunits needlessly wget from git.ceph.com #12685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 4602884)
Root of git checkout Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 27b8eac)
Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit cf29477) Conflicts: (all trivial) qa/workunits/fs/test_python.sh qa/workunits/rados/test_python.sh qa/workunits/rbd/rbd_mirror.sh qa/workunits/rbd/rbd_mirror_stress.sh qa/workunits/rbd/test_librbd_python.sh qa/workunits/rbd/test_lock_fence.sh
When you have a relative path you have to include the extension. Weird. Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 5666fd6) Conflicts: qa/workunits/fs/test_python.sh (not in hammer) qa/workunits/rbd/test_librbd_python.sh (no valgrind in hammer)
Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 72d73b8)
If we checkout ceph-ci.git, and don't find a branch, we'll try again from ceph.git. But the checkout will already exist and the clone will fail, so we'll still fail to find the branch. The same can happen if a previous workunit task already checked out the repo. Fix by removing the repo before checkout (the first and second times). Note that this may break if there are multiple workunit tasks running in parallel on the same role. That is already racy, so if it's happening, we'll want to switch to using a truly unique clonedir for each instantiation. Fixes: http://tracker.ceph.com/issues/18336 Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 2a7013c)
smithfarm
added a commit
that referenced
this pull request
Jan 2, 2017
….ceph.com Reviewed-by: Nathan Cutler <ncutler@suse.com>
smithfarm
changed the title
This commit fixes a regression introduced by cf29477 Fixes: http://tracker.ceph.com/issues/18388 Signed-off-by: Nathan Cutler <ncutler@suse.com> (cherry picked from commit 91231de)
|
@athanatos This just passed rados, rgw, rbd, powercycle, and fs runs at http://tracker.ceph.com/issues/17151#note-38 Do you think it's OK to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/18273
http://tracker.ceph.com/issues/18377
http://tracker.ceph.com/issues/18390