test/librados/snapshots.cc: Fix memory leak #12690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please test this |
1 similar comment
|
Please test this |
Fix for valgrind reported leak of librados::ObjectWriteOperation heap object. Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
badone
force-pushed
the
wip-ceph_test_rados_api_snapshots-valgrind-fixes
branch
from
3b30189
to
06d6550
Compare
tchaikov
reviewed
Jan 3, 2017
| @@ -157,15 +157,13 @@ TEST_F(LibRadosSnapshotsPP, SnapCreateRemovePP) { | |||
| ASSERT_EQ(0, ioctx.remove("foo")); | |||
| ASSERT_EQ(0, ioctx.snap_create("snapbar")); | |||
|
|
|||
| librados::ObjectWriteOperation *op = new librados::ObjectWriteOperation(); | |||
| std::unique_ptr<librados::ObjectWriteOperation> op(new librados::ObjectWriteOperation()); | |||
There was a problem hiding this comment.
might want to use make_unique<librados::ObjectWriteOperation>() .
There was a problem hiding this comment.
@tchaikov I can't find any examples existing in the code base?
$ ag --cpp --ignore ./src/boost/* "make_unique"
$
There was a problem hiding this comment.
my bad, it's a c++14 feature.
There was a problem hiding this comment.
Ahh... yes it is. I thought we must have had a "ceph version" for 11.
tchaikov
approved these changes
Jan 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for valgrind reported leak of librados::ObjectWriteOperation heap
object.
Signed-off-by: Brad Hubbard bhubbard@redhat.com