osd/PrimaryLogPG: optimal pick_newest_available #12695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tchaikov is there bug in build system? i found some PRs build failed due to same error |
|
retest this please |
liewegas
requested changes
Dec 28, 2016
| assert(pg_log.get_missing().is_missing(oid)); | ||
| v = pg_log.get_missing().get_items().find(oid)->second.have; | ||
| pg_missing_item pmi; | ||
| assert(pg_log.get_missing().is_missing(oid, &pmi)); |
There was a problem hiding this comment.
Please do not rely on a side effect of an assert() call. assign the result to a bool local and assert that is true.
There was a problem hiding this comment.
like this ?
- bool is_missing = pg_log.get_missing().is_missing(oid, &pmi);
- assert(is_missing);
- v = pmi.have;
we can get pg_missing_item from is_missing(), no need to find it again. Signed-off-by: huangjun <hjwsm1989@gmail.com>
|
exactly! thanks
|
hjwsm1989
force-pushed
the
mark-unfound-lost
branch
from
777de4c
to
891c099
Compare
tchaikov
reviewed
Dec 29, 2016
| v = pg_log.get_missing().get_items().find(oid)->second.have; | ||
| pg_missing_item pmi; | ||
| bool is_missing = pg_log.get_missing().is_missing(oid, &pmi); | ||
| assert(is_missing); |
There was a problem hiding this comment.
i think we are moving from assert() to ceph_assert(). see the thread of https://www.spinics.net/lists/ceph-devel/msg31049.html
There was a problem hiding this comment.
hasn't happened yet, tho, can be fixed up later
liewegas
approved these changes
Dec 29, 2016
|
retest this please |
liewegas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can get pg_missing_item from is_missing(), no need to find it again.
Signed-off-by: huangjun hjwsm1989@gmail.com