mon/OSDMonitor: set last_force_op_resend on overlay pool too #12712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently set the last_force_op_resend field on the base pool when we set or clear the overlay. Set it on the cache/overlay pool too. The Objecter should resend even with a change only to the base pool, but the OSD needs to see the change on the overlay pool to correctly discard the op. Fixes: http://tracker.ceph.com/issues/18366 Signed-off-by: Sage Weil <sage@redhat.com>
tchaikov
approved these changes
Jan 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently set the last_force_op_resend field on the
base pool when we set or clear the overlay. Set it on
the cache/overlay pool too. The Objecter should resend
even with a change only to the base pool, but the OSD
needs to see the change on the overlay pool to correctly
discard the op.
Fixes: http://tracker.ceph.com/issues/18366
Signed-off-by: Sage Weil sage@redhat.com