jewel: rgw: multisite: coroutine deadlock in RGWMetaSyncCR after ECANCELED errors #12738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RGWCoroutinesManager::run() was setting ret = -ECANCELED to break out of the loop when it sees going_down. coroutines that failed with -ECANCELED were confusing this logic and leading to coroutine deadlock assertions below. when we hit the going_down case, set a 'canceled' flag, and check that flag when deciding whether to break out of the loop Fixes: http://tracker.ceph.com/issues/17465 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 73cd8df)
smithfarm
changed the title
|
This passed RGW runs at http://tracker.ceph.com/issues/17851#note-50 and http://tracker.ceph.com/issues/17851#note-58 |
|
smithfarm
pushed a commit
to smithfarm/ceph
that referenced
this pull request
Feb 2, 2017
…operly Catch decode errors so osd doesn't crash on corrupt OI_ATTR or SS_ATTR Use boost::optional<> to make current state clearer Create next_clone as needed using head/curclone Add equivalent logic after getting to end of scrubmap.objects Fixes: ceph#12738 Signed-off-by: David Zafman <dzafman@redhat.com> (cherry picked from commit a23036c) Conflicts: src/osd/ReplicatedPG.cc (no num_objects_pinned in hammer) src/osd/ReplicatedPG.h (no get_temp_recovery_object() in hammer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/18286