Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph_test_rados_api_watch_notify: move global variables into test class #12751

Merged
merged 1 commit into from Jan 3, 2017

Conversation

tchaikov
Copy link
Contributor

@tchaikov tchaikov commented Jan 3, 2017

so the class instances using mempool are destructed before the mempools
are destroyed. this avoids the "invalid read" issue reported by
valgrind.

Fixes: http://tracker.ceph.com/issues/18395
Signed-off-by: Kefu Chai kchai@redhat.com

so the class instances using mempool are destructed before the mempools
are destroyed. this avoids the "invalid read" issue reported by
valgrind.

Fixes: http://tracker.ceph.com/issues/18395
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov tchaikov requested a review from badone January 3, 2017 06:26
@badone badone self-assigned this Jan 3, 2017
Copy link
Contributor

@badone badone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test locally and LGTM. Thanks for your help on this buddy.

@badone badone merged commit a945407 into ceph:master Jan 3, 2017
@tchaikov tchaikov deleted the wip-18395 branch January 3, 2017 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants