cmake: search for Keyutils in default paths #12769
Conversation
| @@ -13,7 +13,7 @@ INCLUDE(CheckCXXSymbolExists) | |||
|
|
|||
| # include dir | |||
|
|
|||
| find_path(KEYUTILS_INCLUDE_DIR keyutils.h NO_DEFAULT_PATH PATHS | |||
| find_path(KEYUTILS_INCLUDE_DIR keyutils.h PATHS | |||
There was a problem hiding this comment.
@bachp since by default, find_path() searches in /usr/include, could you remove it also?
There was a problem hiding this comment.
also, CheckCXXSymbolExists() is not used, maybe we can take this chance to remove INCLUDE(CheckCXXSymbolExists) at line 12 as well.
There was a problem hiding this comment.
@tchaikov I just did the minimal change to get it working. But I will do the other cleanups as soon later today. Is there a chance to get this backportet to the kraken branch later?
There was a problem hiding this comment.
@bachp to get this PR backported, you might need to create a tracker ticket and update its backport field with "kraken". then connect your commit with that ticket using the notation of "Fixes: http://tracker.ceph.com/issues/12345" in your commit message.
There was a problem hiding this comment.
@tchaikov I update the PR however I was not able to test it as I don't have access to the machine I did the build at the moment.
There was a problem hiding this comment.
@bachp no worries. i will test your patch tomorrow in my build machine.
This makes it more portable Remove /usr/include as it is searched by find_path anyway. Remove unnecessary include that weren't used. Signed-off-by: Pascal Bach <pascal.bach@nextrem.ch>
This makes it more portable
Signed-off-by: Pascal Bach pascal.bach@nextrem.ch