rgw: AbortMultipart request returns NoSuchUpload error if the meta obj doesn't exist

[zhangsw]

In abort multipart request, we delete the meta obj after we delete all uploaded parts. If the meta obj doesn't exist, we return NoSuchUpload.

Signed-off-by: Zhang Shaowen zhangshaowen@cmss.chinamobile.com

[zhangsw]

@cbodley please help review this ,thanks~

[cbodley]

hi @zhangsw, can you explain how you're able to reproduce these errors? it looks like RGWAbortMultipart::execute() is first calling get_multipart_info() to read this object. so a failure to delete it later means that there was a race somewhere. are you sending multiple abort requests at once?

[zhangsw]

@cbodley Actually I haven't met this problem. I find this when I read the code about multipart upload. I think if sending multipart requests at once or lifecycle supports the multipart expiraton, it may occur.

[cbodley]

@zhangsw in either of those cases, i think that returning an error is the right thing to do. 404 NoSuchBucket seems like an odd choice, though - NoSuchUpload is what i'd expect as a client if i sent two abort requests for the same upload

[zhangsw]

@cbodley I first compare this with delete object request that won't return error if the object doesn't exist. But the abort multipart upload is a little different. I think NoSuchUpload is the better choice.

[zhangsw]

@cbodley I've updated it.