Improve vstart_runner to (optionally) create its own cluster #12800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 5, 2017 13:43
Instead of hunting around the filesystem for ceph-qa-suite, get it from our own location. Signed-off-by: John Spray <john.spray@redhat.com>
Previously this could get hung up if we killed one PID and then the daemon reappears with a different one (perhaps because we caught it during daemonization?) Signed-off-by: John Spray <john.spray@redhat.com>
Useful for vstart_runner.py to create a cluster with no filesystem (CephFSTestCase does the filesystem creation) Signed-off-by: John Spray <john.spray@redhat.com>
Convenient when you want to create a fresh cluster each test run: just pass --create and you'll get a cluster with the right number of daemons for the tests you're running. Signed-off-by: John Spray <john.spray@redhat.com>
batrick
requested changes
Jan 11, 2017
| @@ -3,16 +3,16 @@ | |||
| ceph instance instead of a packaged/installed cluster. Use this to turn around test cases | |||
| quickly during development. | |||
|
|
|||
| Usage (assuming teuthology, ceph, ceph-qa-suite checked out in ~/git): | |||
| Simple usage (assuming teuthology, ceph, ceph-qa-suite checked out in ~/git): | |||
There was a problem hiding this comment.
We can remove "ceph-qa-suite" above.
| # Invoke a test using this script, with PYTHONPATH set appropriately | ||
| python ~/git/ceph-qa-suite/tasks/vstart_runner.py | ||
| # Invoke a test using this script | ||
| python ~/git/ceph-qa-suite/tasks/vstart_runner.py --create tasks.cephfs.test_data_scan |
There was a problem hiding this comment.
This command needs updated to ~/git/ceph/qa/....
| # Invoke a test using this script | ||
| python ~/git/ceph-qa-suite/tasks/vstart_runner.py --create tasks.cephfs.test_data_scan | ||
|
|
||
| Alternative usage: | ||
|
|
||
| # Alternatively, if you use different paths, specify them as follows: | ||
| LD_LIBRARY_PATH=`pwd`/lib PYTHONPATH=~/git/teuthology:~/git/ceph-qa-suite:`pwd`/../src/pybind:`pwd`/lib/cython_modules/lib.2 python ~/git/ceph-qa-suite/tasks/vstart_runner.py |
There was a problem hiding this comment.
These paths should be updated too.
|
I tried running the example test:
I had to fix a few permission denied errors by adding some sudos. Here's a patch: After fixing that, I ran across a strange error or newly uncovered bug. A To debug, I added a stat after the creation of Here's the So it went to owner root and permissions 0500. Looks like a bug or is this something else? |
|
To be clear, the patch doesn't necessarily need to be part of this PR I think and the bug is obviously a separate problem. What do you think @jcsp? |
|
@batrick when cephfs-data-scan injects a file from just its data objects, it invents some new metadata -- the uid/gid gets set to root/root. Last I ran these tests they definitely didn't require root, I wonder if you've changed machines and need to update configuration to enable mounting ceph fuse as non-root? |
Isn't that damage supposed to be repaired before getfattr gets executed?
I'm using my laptop as the rex machines' disks are full. I am able to do fuse mounts as a normal user. I was trying to resolve problems I saw here after a failure (undoing my patch and retrying): I had noticed the Looking back in the logs, I remember I also saw this: which made me think ceph-fuse had failed to start but now I see it was just normal log output after the process exited. So I think I don't actually need root for ceph-fuse (except for the dcache consistency) but I still have this chmod problem. Have you seen this before? |
...to use paths pointing to ceph tree, not ceph-qa-suite tree. Signed-off-by: John Spray <john.spray@redhat.com>
|
Updated the docstring |
|
@batrick it looks like somehow LocalFuseMount (vstart_runners special version) isn't getting used somehow on your system -- avoiding the chmod is one of the reasons it exists. I'm pretty sure this was working on my desktop but I can check when I get home |
|
@batrick yeah, this definitely works for me as an unprivileged user -- I suspect the breakage is either nothing to do with this PR, or you've got something funny in your python paths? |
|
I will give it another try. Maybe is something misconfigured, ya. |
|
@jcsp, tried again and got the same error. I don't have anything in my PYTHONPATH. I'm just using a virtualenv with teuthology and then starting vstart_runner.py: By the debug log, it appears it is using LocalFuseMount as expected. In any case I think you can merge this if you want. This is most likely not relating to this PR. Other tests like tasks.cephfs.test_readahead work just fine. |
batrick
approved these changes
Jan 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is possible now that the qa-suite code is in the main ceph repo