mon/PGMonitor: fix description for ceph pg ls, etc. #12807
Conversation
|
it would be better to squash commits like: |
|
This looks reasonable to me. @tchaikov What do you think? |
|
@xiexingguo will take a look tmr. |
| @@ -155,6 +155,7 @@ COMMAND("pg ls-by-osd " \ | |||
| "list pg on osd [osd]", "pg", "r", "cli,rest") | |||
| COMMAND("pg ls " \ | |||
| "name=pool,type=CephInt,req=false " \ | |||
| "name=osd,type=CephInt,req=false " \ | |||
There was a problem hiding this comment.
i don't think "pg ls" command accepts three optional arguments. it does accept two optional argument.
the reason why else if (prefix == "pg ls") { branch checks for the "pool" is just that it is reused by "pg ls-by-pool", and "pg ls-by-pool" sets the "pool" argument programmatically:
cmd_putval(g_ceph_context, cmdmap, "pool", pool);There was a problem hiding this comment.
yeah, i know the trick :) thank you for your detailed explanation!
if ceph command accepts named arguments, maybe we could change it from positional argument to named argument. anyway, i will drop the second commit for now.
There was a problem hiding this comment.
i don't really think we should expose the implementation details in the help message.
| @@ -142,7 +142,7 @@ COMMAND("pg dump_stuck " \ | |||
| COMMAND("pg ls-by-pool " \ | |||
| "name=poolstr,type=CephString " \ | |||
| "name=states,type=CephChoices,strings=active|clean|down|replay|scrubbing|degraded|inconsistent|peering|repair|recovering|backfill_wait|incomplete|stale|remapped|deep_scrub|backfill|backfill_toofull|recovery_wait|undersized|activating|peered,n=N,req=false ", \ | |||
| "list pg with pool = [poolname | poolid]", "pg", "r", "cli,rest") | |||
| "list pg with pool = [poolname]", "pg", "r", "cli,rest") | |||
There was a problem hiding this comment.
please update the man page accordingly.
|
@runsisi ping? |
Signed-off-by: runsisi <runsisi@zte.com.cn>
runsisi
force-pushed
the
wip-fix-pg-ls
branch
from
0f39a0f
to
1852dd2
Compare
|
@liuchang0812 it's two commits for different purposes :) |
|
@tchaikov sorry for the late response, i was absent from work for a few days :) |
ceph pg ls-by-pooldoes not supportpoolid, so modify the description for itosdidas an arg forceph pg ls, so we can support both:ceph pg ls <poolid> <osdid> <states>andceph pg ls <poolid> <states>Signed-off-by: runsisi runsisi@zte.com.cn