Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msg/async: avoid atomic variable overhead #12809

Merged
merged 1 commit into from Jan 11, 2017
Merged

msg/async: avoid atomic variable overhead #12809

merged 1 commit into from Jan 11, 2017

Conversation

wjin
Copy link
Contributor

@wjin wjin commented Jan 6, 2017

  1. there is already a lock to protect the count
  2. no need to send signal during each callback

Signed-off-by: Wei Jin wjin.cn@gmail.com

@wjin
msg/async: avoid atomic variable overhead
2421010 
1) there is already a lock to protect the count
2) no need to send signal during each callback

Signed-off-by: Wei Jin <wjin.cn@gmail.com>
@tchaikov
Copy link
Contributor 

/home/jenkins-build/build/workspace/ceph-pull-requests/qa/workunits/cephtool/test.sh:1776: test_mon_crushmap_validation:  local crushtool_path=/tmp/cephtool.wEP/crushtool
/home/jenkins-build/build/workspace/ceph-pull-requests/qa/workunits/cephtool/test.sh:1777: test_mon_crushmap_validation:  touch /tmp/cephtool.wEP/crushtool
/home/jenkins-build/build/workspace/ceph-pull-requests/qa/workunits/cephtool/test.sh:1778: test_mon_crushmap_validation:  chmod +x /tmp/cephtool.wEP/crushtool
//home/jenkins-build/build/workspace/ceph-pull-requests/qa/workunits/cephtool/test.sh:1779: test_mon_crushmap_validation:  ceph-conf --show-config-value crushtool
/home/jenkins-build/build/workspace/ceph-pull-requests/qa/workunits/cephtool/test.sh:1779: test_mon_crushmap_validation:  local crushtool_path_old=crushtool
/home/jenkins-build/build/workspace/ceph-pull-requests/qa/workunits/cephtool/test.sh:1780: test_mon_crushmap_validation:  ceph tell 'mon.*' injectargs --crushtool /tmp/cephtool.wEP/crushtool
2017-01-06 10:23:44.538645 7f08ad24a700 -1 WARNING: all dangerous and experimental features are enabled.
2017-01-06 10:23:44.542396 7f08ad24a700 -1 WARNING: all dangerous and experimental features are enabled.
mon.a: injectargs:crushtool = '/tmp/cephtool.wEP/crushtool' 
mon.b: injectargs:crushtool = '/tmp/cephtool.wEP/crushtool' 
mon.c: injectargs:crushtool = '/tmp/cephtool.wEP/crushtool' 
/home/jenkins-build/build/workspace/ceph-pull-requests/qa/workunits/cephtool/test.sh:1782: test_mon_crushmap_validation:  printf '%s\n' '#!/bin/sh
       cat > /dev/null
       exit 0'
/home/jenkins-build/build/workspace/ceph-pull-requests/qa/workunits/cephtool/test.sh:1787: test_mon_crushmap_validation:  ceph osd setcrushmap -i /tmp/cephtool.wEP/map
2017-01-06 10:23:44.999583 7fbd09abd700 -1 WARNING: all dangerous and experimental features are enabled.
2017-01-06 10:23:45.007704 7fbd09abd700 -1 WARNING: all dangerous and experimental features are enabled.
Error EINVAL: Failed crushmap test: /tmp/cephtool.wEP/crushtool: timed out (5 sec)
/home/jenkins-build/build/workspace/ceph-pull-requests/qa/workunits/cephtool/test.sh:1: test_mon_crushmap_validation:  rm -fr /tmp/cephtool.wEP

retest this please.

@tchaikov tchaikov self-assigned this Jan 10, 2017
@tchaikov
Copy link
Contributor

http://pulpito.ceph.com/kchai-2017-01-10_14:07:09-rados-wip-kefu-testing---basic-mira/

@tchaikov tchaikov merged commit 87256a1 into ceph:master Jan 11, 2017
@wjin wjin deleted the optimize_atomic branch January 16, 2017 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuyuyu101 yuyuyu101 yuyuyu101 approved these changes

Assignees

@tchaikov tchaikov

Labels
cleanup needs-qa wip-kefu-testing
Projects
None yet
Milestone
No milestone
3 participants
@wjin @tchaikov @yuyuyu101