Keyvaluestore enhance #1282
Merged
Keyvaluestore enhance #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collection is a special object in KeyValueStore, if exists collection modify, this object will be hold. When exists check collection, it will be dead lock to try to access this object. Now lookup transaction cache first to ensure no collection object exists already. Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
The perf counter of FileStore can shared with other ObjectStore backend, so move it to ObjectStore and adjust position to let other KeyValueStore refer to. Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
In some situations, we need to ensure header is held and try to read, so read interfaces need to accept header argument to allow. Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
If the first chunk of object is not read entirely, the current implementation will contain it entirely which make wrong. Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Before we copy lock implementation from DBObjectMap which provide with two locks for header. Here just unify it to make ease. Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
A single write call may need several keys in the backend kv store. Let get these keys one time. Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
The goal of "check_coll" is aimed to ensure the collection is exists. But the create and delete of collection already ensured by OSD, just remove check. Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Each object modify will increase SequencePosition and sync it to disk Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
KeyValueStore use kv backend to detect errors and nearly can't know the actual reason for error. Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
| @@ -650,6 +650,13 @@ | |||
| OPTION(journal_aio, OPT_BOOL, true) | |||
| OPTION(journal_force_aio, OPT_BOOL, false) | |||
|
|
|||
| OPTION(keyvaluestore_queue_max_ops, OPT_INT, 50) | |||
| OPTION(keyvaluestore_queue_max_bytes, OPT_INT, 100 << 20) | |||
| OPTION(keyvaluestore_check_backend, OPT_BOOL, 0) // Expensive debugging check on sync | |||
There was a problem hiding this comment.
keyvaluestore_debug_check_backend?
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
liewegas
pushed a commit
to liewegas/ceph
that referenced
this pull request
Dec 7, 2016
fs: unify common parts of sub-suites Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeyValueStore enhancement: