mon: optracker's initiated_at timestamp should not be NULL #12826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiumxNL
force-pushed
the
fix-op-tracker-initiate
branch
from
206b869
to
2aab6bf
Compare
|
@tchaikov pls review, thanks! |
yuyuyu101
reviewed
Jan 9, 2017
| @@ -86,7 +86,8 @@ struct MonOpRequest : public TrackedOp { | |||
| op_type_t op_type; | |||
|
|
|||
| MonOpRequest(Message *req, OpTracker *tracker) : | |||
| TrackedOp(tracker, req->get_recv_stamp()), | |||
| TrackedOp(tracker, | |||
| req->get_recv_stamp() ? req->get_recv_stamp() : ceph_clock_now(g_ceph_context)), | |||
There was a problem hiding this comment.
ceph_clock_now now deprecates argument. plz don't pass g_ceph_context
LiumxNL
force-pushed
the
fix-op-tracker-initiate
branch
from
2aab6bf
to
b6076e3
Compare
tchaikov
reviewed
Jan 9, 2017
| @@ -86,7 +86,8 @@ struct MonOpRequest : public TrackedOp { | |||
| op_type_t op_type; | |||
|
|
|||
| MonOpRequest(Message *req, OpTracker *tracker) : | |||
| TrackedOp(tracker, req->get_recv_stamp()), | |||
| TrackedOp(tracker, | |||
| req->get_recv_stamp() ? req->get_recv_stamp() : ceph_clock_now()), | |||
There was a problem hiding this comment.
you are actually using the operator double as operator bool. could you instead use is_zero() instead? and wrap the line at 80 chars.
so using ceph_clock_now() instead to make optracker happy Signed-off-by: Mingxin Liu <mingxin@xsky.com>
LiumxNL
force-pushed
the
fix-op-tracker-initiate
branch
from
b6076e3
to
ecb967a
Compare
|
@tchaikov updated |
tchaikov
approved these changes
Jan 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mon may track a self-initiated message, recv_stamp remains unset
so using ceph_clock_now() instead to make optracker happy
Signed-off-by: Mingxin Liu mingxin@xsky.com