OSDMonitor: only reject MOSDBoot based on up_from if inst matches #12868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the osd actually restarts, there is no guarrantee that the epoch will advance past up_from. If the inst is different, it can't really be a dup. At worst, it might be a queued MOSDBoot from a previous inst, but in that case, the real inst would see itself marked up, and then back down causing it to try booting again. Fixes: http://tracker.ceph.com/issues/17899 Signed-off-by: Samuel Just <sjust@redhat.com> (cherry picked from commit 033ad5b)
liewegas
approved these changes
Jan 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the osd actually restarts, there is no guarrantee that the epoch will
advance past up_from. If the inst is different, it can't really be a
dup. At worst, it might be a queued MOSDBoot from a previous inst, but
in that case, the real inst would see itself marked up, and then back
down causing it to try booting again.
Fixes: http://tracker.ceph.com/issues/17899
Signed-off-by: Samuel Just sjust@redhat.com
(cherry picked from commit 033ad5b)