client: populate metadata during mount #12915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we avoid having to over-write the "root" metadata during mount, and any user-set overrides (such as bad values injected by tests) will survive. Because Client instances may also open sessions without mounting to send commands, add a call into populate_metadata from mds_command as well. Fixes: http://tracker.ceph.com/issues/18361 Signed-off-by: John Spray <john.spray@redhat.com>
ukernel
reviewed
Jan 13, 2017
| @@ -1943,7 +1941,9 @@ void Client::populate_metadata() | |||
| metadata["entity_id"] = cct->_conf->name.get_id(); | |||
|
|
|||
| // Our mount position | |||
| metadata["root"] = cct->_conf->client_mountpoint; | |||
There was a problem hiding this comment.
@client_mountpoint is not referenced any more. remove it from config option?
There was a problem hiding this comment.
It's still used from ceph_fuse.cc (and via the "-r" argument)
ukernel
approved these changes
Jan 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we avoid having to over-write the "root"
metadata during mount, and any user-set overrides (such
as bad values injected by tests) will survive.
Because Client instances may also open sessions without
mounting to send commands, add a call into populate_metadata
from mds_command as well.
Fixes: http://tracker.ceph.com/issues/18361
Signed-off-by: John Spray john.spray@redhat.com