ceph-disk: use correct user in check_journal_req #12947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ceph-disk tool calls ceph-osd to check the journal requirements using OSD id 0. This creates a log file for osd-0 on the system using the current user/group for file permissions. When ceph-disk is run as root this makes the file owned by root which makes the osd daemon for osd.0 unable to write to its own log file. This commit changes the journal reqs calls of ceph-osd to pass the ceph user and group so ceph-osd creates the log file with the appropriate permissions. Fixes: http://tracker.ceph.com/issues/18538 Signed-off-by: Samuel Matzek <smatzek@us.ibm.com>
liewegas
changed the title
liewegas
approved these changes
Jan 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ceph-disk tool calls ceph-osd to check the journal requirements
using OSD id 0. This creates a log file for osd-0 on the system
using the current user/group for file permissions. When ceph-disk
is run as root this makes the file owned by root which makes
the osd daemon for osd.0 unable to write to its own log file.
This commit changes the journal reqs calls of ceph-osd to pass
the ceph user and group so ceph-osd creates the log file with the
appropriate permissions.
Fixes: http://tracker.ceph.com/issues/18538
Signed-off-by: Samuel Matzek smatzek@us.ibm.com