rgw: valgrind fixes for kraken #12949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: http://tracker.ceph.com/issues/18407 Fixes: http://tracker.ceph.com/issues/18414 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 7a4975a)
Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 1d586f7)
if the coroutine is canceled before collect_children() can clean up all of its child stacks, those stack refs will leak. store these stacks as boost::intrusive_ptr so the ref is dropped automatically on destruction Fixes: http://tracker.ceph.com/issues/18300 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 060fe72)
Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 7b3532e)
Fixes: http://tracker.ceph.com/issues/18412 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 34a2edb)
liewegas
approved these changes
Jan 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/18561
http://tracker.ceph.com/issues/18564
http://tracker.ceph.com/issues/18782