rgw_file: split last argv on ws, if provided #12965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattbenjamin the commit itself looks ok, but wouldn't this break command line options that have a space in them? e.g., |
|
@yehudasa well, yeah; however, it will never be passed from the cmdline; the intent is to properly implement the "init_arg" extra args that I added to ganesha args processing; adding some kind of quoting would be ok, but it feels like overkill |
|
@mattbenjamin wouldn't it make more sense to pre-parse the args and pass to ganesha whatever we get in |
yehudasa
approved these changes
Jan 27, 2017
|
@yehudasa ok, thanks for the ruling: if you're ok with the extra logic, I'll implement or locate something appropriate |
This is intended to allow an "extra" unparsed argument string containing various cmdline options to be passed as the last argument in the argv array of librgw_create(), which nfs-ganesha is expecting to happen. While at it, hook env_args() too. Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
mattbenjamin
force-pushed
the
wip-librgw-expand-argv
branch
from
2194dbc
to
fbc19e4
Compare
|
For the record the jewel backport of this change is going in as #14230 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to allow an "extra" unparsed argument string
containing various cmdline options to be passed as the last argument
in the argv array of librgw_create(), which nfs-ganesha is
expecting to happen.
While at it, hook env_args() too.
Signed-off-by: Matt Benjamin mbenjamin@redhat.com