[DNM] osd/PG: Remove redundant advmap reaction

[badone]

In the Incomplete state there is no longer any reason to check for a
min_size reduction in an advancing map as a reduction in min_size has no
bearing on whether we can recover from Incomplete.

Signed-off-by: Brad Hubbard bhubbard@redhat.com

[liewegas]

Here:

  // We go incomplete if below min_size for ec_pools since backfill
  // does not currently maintain rollbackability
  // Otherwise, we will go "peered", but not "active"
  if (num_want_acting < pool.info.min_size &&
      (pool.info.ec_pool() ||
       !cct->_conf->osd_allow_recovery_below_min_size)) {
    want_acting.clear();
    dout(10) << "choose_acting failed, below min size" << dendl;
    return false;
  }

from choose_acting(). If min_size is reduced, then we may be able to go active...

[badone]

@liewegas looking into this further. I believe this code is still redundant since the default behaviour for the statechart is a forward_event to the next outer state (Peering) and should result in a transition to reset anyway but I need to confirm that and also look at the code you pointed out. This likely means #12936 needs to be revisited and notation added that this all only applies to EC.

[badone]

@liewegas finally got to look at this agin and see what you mean now. I guess we could still remove this code if we moved the check for min_size reduction to the Peering advmap reaction but it probably is more explicit and future proof where it is. Closing this.