rgw: librgw shut #12972
Merged
rgw: librgw shut #12972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbodley
reviewed
Jan 18, 2017
| @@ -182,5 +183,5 @@ int rgw_tools_init(CephContext *cct) | |||
|
|
|||
| void rgw_tools_cleanup() | |||
| { | |||
| ext_mime_map.clear(); | |||
| delete ext_mime_map; | |||
There was a problem hiding this comment.
assign to null after delete
mattbenjamin
force-pushed
the
wip-librgw-shut
branch
2 times, most recently
from
d1f264e
to
9277812
Compare
The shutdown member of RGWLibProcess should be set. Fixes: http://tracker.ceph.com/issues/18585 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
In some librgw shutdown cases, it appears that the shared object runtime has partially destructed the static map when our shutdown code is running. Fixes: http://tracker.ceph.com/issues/18585 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
The call is cognate to removed code in radosgw, and triggers an assert that the crypto module has already been shutdown. With this and preceding changes, I see clean shutdown on abnormal termination of nfs-ganesha during startup. Fixes: http://tracker.ceph.com/issues/18585 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
mattbenjamin
force-pushed
the
wip-librgw-shut
branch
from
9277812
to
4299bfc
Compare
cbodley
approved these changes
Jan 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix librgw shutdown after abnormal termination of library client/nfs-ganesha.
Verified by forcing nfs-ganesha to exit due to network setup failure.