jewel: ReplicatedBackend: take read locks for clone sources during recovery #12978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
|
http://tracker.ceph.com/issues/18583 should be backported at the same time - it fixes a bug in this |
|
@asheplyakov To implement the previous comment, could you please:
If any of this doesn't make sense, just ping me. |
Otherwise, we run the risk of a clone source which hasn't actually come into existence yet being used if we grab a clone which *just* got added the the ssc, but has not yet actually had time to be created (can't rely on message ordering here since recovery messages don't necessarily order with client IO!). Fixes: http://tracker.ceph.com/issues/17831 Signed-off-by: Samuel Just <sjust@redhat.com> (cherry picked from commit 68defc2) Conflicts: src/osd/ReplicatedBackend.cc: PGBackend::failed_push() takes a single pg_shard_t in jewel src/osd/ReplicatedPG.h: trivial: get_obc() is not declared as override in jewel, no pgb_{set,clear}_object_snap_mapping() in jewel
The only users calc_*_subsets might try to read_lock an object which is missing on the primary. Returning false in those cases is perfectly reasonable and avoids the problem. Fixes: http://tracker.ceph.com/issues/18583 Signed-off-by: Samuel Just <sjust@redhat.com> (cherry picked from commit 3833440)
asheplyakov
force-pushed
the
jewel-18581
branch
from
55b7d5d
to
509de4d
Compare
|
@jdurgin thanks for a tip |
|
@jdurgin This passed a rados suite at http://tracker.ceph.com/issues/17851#note-45 with some (few, unrelated) failures. OK to merge? |
|
This passed another rados run at http://tracker.ceph.com/issues/17851#note-53 |
athanatos
added a commit
to athanatos/ceph
that referenced
this pull request
Feb 6, 2017
See: http://tracker.ceph.com/issues/18809 This reverts commit 8e69580, reversing changes made to c05730c.
athanatos
added a commit
to athanatos/ceph
that referenced
this pull request
Feb 7, 2017
See: http://tracker.ceph.com/issues/18809 This reverts commit 8e69580, reversing changes made to c05730c. Signed-off-by: Samuel Just <sjust@redhat.com>
athanatos
added a commit
that referenced
this pull request
Feb 7, 2017
Revert "Merge pull request #12978 from asheplyakov/jewel-18581" Reviewed-by: Josh Durgin <jdurgin@redhat.com>
shinobu-x
pushed a commit
to shinobu-x/ceph
that referenced
this pull request
Feb 23, 2017
See: http://tracker.ceph.com/issues/18809 This reverts commit 8e69580, reversing changes made to c05730c. Signed-off-by: Samuel Just <sjust@redhat.com> (cherry picked from commit 0cf7a61) Conflicts: src/osd/ReplicatedPG.h
shinobu-x
pushed a commit
to shinobu-x/ceph
that referenced
this pull request
Feb 25, 2017
See: http://tracker.ceph.com/issues/18809 This reverts commit 8e69580, reversing changes made to c05730c. Signed-off-by: Samuel Just <sjust@redhat.com> (cherry picked from commit 0cf7a61) Conflicts: src/osd/ReplicatedPG.h
shinobu-x
pushed a commit
to shinobu-x/ceph
that referenced
this pull request
Mar 5, 2017
See: http://tracker.ceph.com/issues/18809 This reverts commit 8e69580, reversing changes made to c05730c. Signed-off-by: Samuel Just <sjust@redhat.com> (cherry picked from commit 0cf7a61)
|
NOTE: this backport was later reverted by #13280 so both the backport and its revert are contained in 10.2.6 |
|
@smithfarm You are great :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/18581
http://tracker.ceph.com/issues/18724