Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jewel: radosgw valgrind "invalid read size 4" RGWGetObj #12997

Merged
merged 2 commits into from Feb 1, 2017
Merged

jewel: radosgw valgrind "invalid read size 4" RGWGetObj #12997

merged 2 commits into from Feb 1, 2017

Conversation

asheplyakov
Copy link

@mattbenjamin
rgw_rados: sanitize dout print in GWRados::get_obj_iterate_cb(...)
585eb48 
We cannot assume pbl may be deferenced.  Per review, move the dout
print into the r < 0 condition--since it's now an error, make it's
trace level 0.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit c0233c4)
@mattbenjamin
rgw_rados: add guard assert in add_io()
c21622d 
Use the iterator-returning insert operation in std::map, check
assert the insert case.  As a side effect, this makes use of the
inserted object record more clear.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit d10c37a)
@tchaikov tchaikov added this to the jewel milestone Jan 19, 2017
@tchaikov tchaikov added the rgw label Jan 19, 2017
@asheplyakov asheplyakov mentioned this pull request Jan 19, 2017
Merged
@ghost ghost added the bug-fix label Jan 25, 2017
@ghost ghost self-assigned this Jan 25, 2017
@smithfarm smithfarm merged commit 2f4990d into ceph:jewel Feb 1, 2017
@smithfarm
Copy link
Contributor

This passed RGW runs at http://tracker.ceph.com/issues/17851#note-50 and http://tracker.ceph.com/issues/17851#note-58

@smithfarm smithfarm mentioned this pull request Feb 1, 2017
Closed
@smithfarm
Copy link
Contributor 

(11:46:45 AM) smithfarm: owasserm: thanks. For jewel integration rgw, then, what it comes down to is verifying that these 6 valgrind failures are all libtcmalloc-related: http://pulpito.front.sepia.ceph.com/smithfarm-2017-01-31_12:35:14-rgw-wip-jewel-backports-distro-basic-smithi/
(11:46:58 AM) smithfarm: owasserm: I will do that now
(11:47:05 AM) owasserm: smithfarm, thanks
(11:47:33 AM) smithfarm: owasserm: and assuming they are tcmalloc related, you said I can directly merge all the rgw PRs? Or do you want me to ask you for review in the PRs first?
(11:47:53 AM) owasserm: smithfarm, yes you can merge them
(11:48:19 AM) smithfarm: ok, will merge and do at least one or two more rgw runs before passing 10.2.6 to QE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix rgw
Projects
None yet
Milestone
jewel
4 participants
@asheplyakov @smithfarm @tchaikov @mattbenjamin