jewel: rgw: multipart upload copy #13068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test this please (jenkins stuck) |
ghost
changed the title
Add multipart uploads copy part feature. Fixes: http://tracker.ceph.com/issues/12790 Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com> (cherry picked from commit 949480c) Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com> (cherry picked from commit 8a7ebee)
Don't read the entire range from source object, read it in parts. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit 4049e47)
also reduce log level for non critical user errors. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit 2bcb3d2)
no need for range.size() Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit 6e9b824)
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit 53521ef)
This fixes a case where objects start with double underscore. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit 29fece3)
mattbenjamin
force-pushed
the
jewel-rgw-multipart-upload-copy
branch
from
1577437
to
1d406e1
Compare
|
@yehudasa can you check this over? special attention to RGWCopyObj::verify_permissions |
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit 4919dc9)
mattbenjamin
force-pushed
the
jewel-rgw-multipart-upload-copy
branch
from
1d406e1
to
514e2ba
Compare
|
looks good
…On Thu, Jan 26, 2017 at 2:06 PM, Matt Benjamin ***@***.***> wrote:
@yehudasa <https://github.com/yehudasa> can you check this over? special
attention to RGWCopyObj::verify_permissions
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13068 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA_QWTFCODnrwyTJvJweY0QMPkLkLqYdks5rWRjQgaJpZM4LrW_3>
.
|
smithfarm
changed the title
Done. |
|
for the record this set of commit did not go through teuthology tests before being merged and will need special attention during the QE phase of the next release. |
|
@smithfarm the missing commit fixing the regression has been added to the merge branch, and has passed 2 rgw suite runs; I'm not sure how to re-open this PR though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/18714