Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

systemd: Start OSDs after MONs #13097

Merged
merged 1 commit into from Feb 8, 2017
Merged

systemd: Start OSDs after MONs #13097

merged 1 commit into from Feb 8, 2017

Conversation

b-ranto
Copy link
Contributor

@b-ranto b-ranto commented Jan 25, 2017

Currently, we start/stop OSDs and MONs simultaneously. This may cause
problems especially when we are shutting down the system. Once the mon
goes down it causes a re-election and the MONs can miss the message
from the OSD that is going down.

Resolves: http://tracker.ceph.com/issues/18516

Signed-off-by: Boris Ranto branto@redhat.com

@b-ranto
systemd: Start OSDs after MONs
7f4acf4 
Currently, we start/stop OSDs and MONs simultaneously. This may cause
problems especially when we are shutting down the system. Once the mon
goes down it causes a re-election and the MONs can miss the message
from the OSD that is going down.

Resolves: http://tracker.ceph.com/issues/18516

Signed-off-by: Boris Ranto <branto@redhat.com>
@gregsfortytwo
Copy link
Member

retest this please

gregsfortytwo
gregsfortytwo approved these changes Jan 25, 2017
View reviewed changes
Copy link
Member

@gregsfortytwo gregsfortytwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Greg Farnum gfarnum@redhat.com

@gregsfortytwo
Copy link
Member

This looks good to me, but I'll leave it open to make sure we didn't bust those unit tests and in case anybody else with more systemd experience wants to comment.

@b-ranto
Copy link
Contributor Author

b-ranto commented Feb 8, 2017

@smithfarm What do you think? Can we merge this?

@smithfarm smithfarm self-requested a review February 8, 2017 20:27
@smithfarm
Copy link
Contributor

Rebased to latest master and pushed wip-osd-after-mon to ceph/ceph-ci.git

@smithfarm
Copy link
Contributor

After it builds, will run a smoke/systemd suite on it.

@smithfarm
Copy link
Contributor

smithfarm commented Feb 8, 2017 •
edited

./virtualenv/bin/teuthology-suite -k distro --machine-type smithi --priority 101 --email ncutler@suse.com --ceph wip-osd-after-mon --suite smoke/systemd --dry-run

fail http://pulpito.ceph.com:80/smithfarm-2017-02-08_21:55:46-smoke:systemd-wip-osd-after-mon-distro-basic-smithi/

@b-ranto
Copy link
Contributor Author

b-ranto commented Feb 8, 2017

@smithfarm great, thanks!

@smithfarm
Copy link
Contributor

ah, nevermind, smoke/systemd is broken atm - see http://pulpito.ceph.com/teuthology-2017-02-08_05:00:07-smoke-master-testing-basic-vps/

@smithfarm smithfarm merged commit fb7dabf into master Feb 8, 2017
@b-ranto b-ranto deleted the wip-osd-after-mon branch February 8, 2017 23:35
@smithfarm
Copy link
Contributor

Tracker issue has empty backport field, so this is master-only until that changes, JFYI

@shinobu-x shinobu-x mentioned this pull request Feb 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktdreyer ktdreyer ktdreyer approved these changes

@gregsfortytwo gregsfortytwo gregsfortytwo approved these changes

@smithfarm smithfarm smithfarm approved these changes

Assignees
No one assigned
Labels
build/ops
Projects
None yet
Milestone
No milestone
4 participants
@b-ranto @gregsfortytwo @smithfarm @ktdreyer