Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jewel: rgw: Realm set does not create a new period #13182

Merged
merged 3 commits into from Feb 1, 2017
Merged

jewel: rgw: Realm set does not create a new period #13182

merged 3 commits into from Feb 1, 2017

Conversation

smithfarm
Copy link
Contributor

@oritwas @smithfarm
radosgw-admin: realm set should create a new realm
3cd42f4 
Fixes: http://tracker.ceph.com/issues/18333
Signed-off-by: Orit Wasserman <owasserm@redhat.com>
(cherry picked from commit e23339c)
@oritwas @smithfarm
radosgw-admin: relam set can use input redirection
e4b6cf6 
Signed-off-by: Orit Wasserman <owasserm@redhat.com>
(cherry picked from commit b8b3ae3)

Conflicts:
	src/rgw/rgw_admin.cc ("return EINVAL" in master, "return -EINVAL" in
              jewel; but it's irrelevant because the whole block is deleted)
@oritwas @smithfarm
radosgw-admin: check for name mistmatch in realm set
73d2114 
Signed-off-by: Orit Wasserman <owasserm@redhat.com>
(cherry picked from commit 4facc5f)
@smithfarm smithfarm self-assigned this Jan 29, 2017
@smithfarm smithfarm added this to the jewel milestone Jan 29, 2017
@smithfarm smithfarm merged commit 96626c2 into ceph:jewel Feb 1, 2017
@smithfarm smithfarm deleted the wip-18498-jewel branch February 1, 2017 22:58
@smithfarm
Copy link
Contributor Author

This passed RGW runs at http://tracker.ceph.com/issues/17851#note-50 and http://tracker.ceph.com/issues/17851#note-58

@smithfarm
Copy link
Contributor Author 

(11:46:45 AM) smithfarm: owasserm: thanks. For jewel integration rgw, then, what it comes down to is verifying that these 6 valgrind failures are all libtcmalloc-related: http://pulpito.front.sepia.ceph.com/smithfarm-2017-01-31_12:35:14-rgw-wip-jewel-backports-distro-basic-smithi/
(11:46:58 AM) smithfarm: owasserm: I will do that now
(11:47:05 AM) owasserm: smithfarm, thanks
(11:47:33 AM) smithfarm: owasserm: and assuming they are tcmalloc related, you said I can directly merge all the rgw PRs? Or do you want me to ask you for review in the PRs first?
(11:47:53 AM) owasserm: smithfarm, yes you can merge them
(11:48:19 AM) smithfarm: ok, will merge and do at least one or two more rgw runs before passing 10.2.6 to QE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smithfarm smithfarm

Labels
bug-fix rgw
Projects
None yet
Milestone
jewel
2 participants
@smithfarm @oritwas