Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: ignore bogus ceph-objectstore-tool error in ceph_manager #13194

Merged
merged 1 commit into from Feb 2, 2017
Merged

tests: ignore bogus ceph-objectstore-tool error in ceph_manager #13194

merged 1 commit into from Feb 2, 2017

Conversation

smithfarm
Copy link
Contributor

Fixes: http://tracker.ceph.com/issues/16263
Signed-off-by: Nathan Cutler ncutler@suse.com

@smithfarm smithfarm requested review from a user, jdurgin and dzafman January 30, 2017 23:48
@smithfarm
Copy link
Contributor Author

Relevant log excerpt is:

2017-01-30T14:11:24.615 INFO:tasks.thrashosds.thrasher:Moving pg 0.13 from osd.3 to osd.1
2017-01-30T14:11:24.615 INFO:tasks.thrashosds.thrasher:Transfer export file from ubuntu@smithi156.front.sepia.ceph.com to ubuntu@smithi053.front.sepia.ceph.com
2017-01-30T14:11:24.626 DEBUG:teuthology.orchestra.remote:smithi156:/home/ubuntu/cephtest/ceph.data/exp.0.13.3 is 7KB
2017-01-30T14:11:24.696 INFO:teuthology.orchestra.run.smithi053:Running: 'sudo adjust-ulimits ceph-objectstore-tool --data-path /var/lib/ceph/osd/ceph-1 --journal-path /var/lib/ceph/osd/ceph-1/journal --log-file=/var/log/ceph/objectstore_tool.\\$pid.log --op import --file /home/ubuntu/cephtest/ceph.data/exp.0.13.3'
2017-01-30T14:11:24.736 INFO:teuthology.orchestra.run.smithi053.stdout:Importing pgid 0.13
2017-01-30T14:11:24.737 INFO:teuthology.orchestra.run.smithi053.stderr:ERROR: Export PG's map_epoch 1202 > OSD's epoch 986
2017-01-30T14:11:24.738 INFO:teuthology.orchestra.run.smithi053.stderr:The OSD you are using is older than the exported PG
2017-01-30T14:11:24.738 INFO:teuthology.orchestra.run.smithi053.stderr:Either use another OSD or join selected OSD to cluster to update it first
2017-01-30T14:11:24.741 INFO:tasks.thrashosds.thrasher:Traceback (most recent call last):
  File "/home/teuthworker/src/git.ceph.com_ceph-c_wip-jewel-backports/qa/tasks/ceph_manager.py", line 673, in wrapper
    return func(self)
  File "/home/teuthworker/src/git.ceph.com_ceph-c_wip-jewel-backports/qa/tasks/ceph_manager.py", line 727, in do_thrash
    self.choose_action()()
  File "/home/teuthworker/src/git.ceph.com_ceph-c_wip-jewel-backports/qa/tasks/ceph_manager.py", line 296, in kill_osd
    format(ret=proc.exitstatus))
Exception: ceph-objectstore-tool: import failure with status 1

dzafman
dzafman approved these changes Feb 1, 2017
View reviewed changes
Copy link
Contributor

@dzafman dzafman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jdurgin jdurgin merged commit 21cdcfc into ceph:master Feb 2, 2017
@smithfarm smithfarm deleted the wip-16263 branch February 6, 2017 17:33
@smithfarm
Copy link
Contributor Author

Oops, this caused a regression. Fixing now.

smithfarm added a commit to smithfarm/ceph that referenced this pull request Feb 6, 2017
@smithfarm
tests: fix regression in qa/tasks/ceph_master.py
03e0b1c 
ceph#13194 introduced a regression:

2017-02-06T16:14:23.162 INFO:tasks.thrashosds.thrasher:Traceback (most recent call last):
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 722, in wrapper
    return func(self)
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 839, in do_thrash
    self.choose_action()()
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 305, in kill_osd
    output = proc.stderr.getvalue()
AttributeError: 'NoneType' object has no attribute 'getvalue'

Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm smithfarm mentioned this pull request Feb 6, 2017
Merged
smithfarm added a commit to smithfarm/ceph that referenced this pull request Feb 6, 2017
@smithfarm
tests: fix regression in qa/tasks/ceph_master.py
faf0f2e 
ceph#13194 introduced a regression:

2017-02-06T16:14:23.162 INFO:tasks.thrashosds.thrasher:Traceback (most recent call last):
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 722, in wrapper
    return func(self)
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 839, in do_thrash
    self.choose_action()()
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 305, in kill_osd
    output = proc.stderr.getvalue()
AttributeError: 'NoneType' object has no attribute 'getvalue'

Fixes: http://tracker.ceph.com/issues/16263
Signed-off-by: Nathan Cutler <ncutler@suse.com>
smithfarm added a commit to smithfarm/ceph that referenced this pull request Feb 6, 2017
@smithfarm
tests: fix regression in qa/tasks/ceph_master.py
a161c57 
ceph#13194 introduced a regression:

2017-02-06T16:14:23.162 INFO:tasks.thrashosds.thrasher:Traceback (most recent call last):
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 722, in wrapper
    return func(self)
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 839, in do_thrash
    self.choose_action()()
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 305, in kill_osd
    output = proc.stderr.getvalue()
AttributeError: 'NoneType' object has no attribute 'getvalue'

Fixes: http://tracker.ceph.com/issues/16263
Signed-off-by: Nathan Cutler <ncutler@suse.com>
smithfarm added a commit to smithfarm/ceph that referenced this pull request Feb 6, 2017
@smithfarm
tests: fix regression in qa/tasks/ceph_master.py
685710b 
ceph#13194 introduced a regression:

2017-02-06T16:14:23.162 INFO:tasks.thrashosds.thrasher:Traceback (most recent call last):
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 722, in wrapper
    return func(self)
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 839, in do_thrash
    self.choose_action()()
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 305, in kill_osd
    output = proc.stderr.getvalue()
AttributeError: 'NoneType' object has no attribute 'getvalue'

This is because we neglected to pass "stderr=StringIO()" to run().

Fixes: http://tracker.ceph.com/issues/16263
Signed-off-by: Nathan Cutler <ncutler@suse.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
smithfarm added a commit to smithfarm/ceph that referenced this pull request Feb 6, 2017
@smithfarm
tests: fix regression in qa/tasks/ceph_master.py
9ee12df 
ceph#13194 introduced a regression:

2017-02-06T16:14:23.162 INFO:tasks.thrashosds.thrasher:Traceback (most recent call last):
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 722, in wrapper
    return func(self)
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 839, in do_thrash
    self.choose_action()()
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 305, in kill_osd
    output = proc.stderr.getvalue()
AttributeError: 'NoneType' object has no attribute 'getvalue'

This is because the original patch failed to pass "stderr=StringIO()" to run().

Fixes: http://tracker.ceph.com/issues/16263
Signed-off-by: Nathan Cutler <ncutler@suse.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
smithfarm added a commit to smithfarm/ceph that referenced this pull request Feb 6, 2017
@smithfarm
tests: fix regression in qa/tasks/ceph_master.py
db2582e 
ceph#13194 introduced a regression:

2017-02-06T16:14:23.162 INFO:tasks.thrashosds.thrasher:Traceback (most recent call last):
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 722, in wrapper
    return func(self)
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 839, in do_thrash
    self.choose_action()()
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 305, in kill_osd
    output = proc.stderr.getvalue()
AttributeError: 'NoneType' object has no attribute 'getvalue'

This is because the original patch failed to pass "stderr=StringIO()" to run().

Fixes: http://tracker.ceph.com/issues/16263
Signed-off-by: Nathan Cutler <ncutler@suse.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
smithfarm added a commit to smithfarm/ceph that referenced this pull request Feb 7, 2017
@smithfarm
tests: fix regression in qa/tasks/ceph_master.py
bfb46ce 
ceph#13194 introduced a regression:

2017-02-06T16:14:23.162 INFO:tasks.thrashosds.thrasher:Traceback (most recent call last):
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 722, in wrapper
    return func(self)
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 839, in do_thrash
    self.choose_action()()
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 305, in kill_osd
    output = proc.stderr.getvalue()
AttributeError: 'NoneType' object has no attribute 'getvalue'

This is because the original patch failed to pass "stderr=StringIO()" to run().

Fixes: http://tracker.ceph.com/issues/16263
Signed-off-by: Nathan Cutler <ncutler@suse.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit db2582e)
smithfarm added a commit to smithfarm/ceph that referenced this pull request Feb 7, 2017
@smithfarm
tests: fix regression in qa/tasks/ceph_master.py
5c328f0 
ceph#13194 introduced a regression:

2017-02-06T16:14:23.162 INFO:tasks.thrashosds.thrasher:Traceback (most recent call last):
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 722, in wrapper
    return func(self)
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 839, in do_thrash
    self.choose_action()()
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 305, in kill_osd
    output = proc.stderr.getvalue()
AttributeError: 'NoneType' object has no attribute 'getvalue'

This is because the original patch failed to pass "stderr=StringIO()" to run().

Fixes: http://tracker.ceph.com/issues/16263
Signed-off-by: Nathan Cutler <ncutler@suse.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit db2582e)
smithfarm added a commit to smithfarm/ceph that referenced this pull request Feb 7, 2017
@smithfarm
tests: fix regression in qa/tasks/ceph_master.py
c968ed3 
ceph#13194 introduced a regression:

2017-02-06T16:14:23.162 INFO:tasks.thrashosds.thrasher:Traceback (most recent call last):
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 722, in wrapper
    return func(self)
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 839, in do_thrash
    self.choose_action()()
  File "/home/teuthworker/src/github.com_ceph_ceph_master/qa/tasks/ceph_manager.py", line 305, in kill_osd
    output = proc.stderr.getvalue()
AttributeError: 'NoneType' object has no attribute 'getvalue'

This is because the original patch failed to pass "stderr=StringIO()" to run().

Fixes: http://tracker.ceph.com/issues/16263
Signed-off-by: Nathan Cutler <ncutler@suse.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit db2582e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzafman dzafman dzafman approved these changes

@jdurgin jdurgin Awaiting requested review from jdurgin

Assignees
No one assigned
Labels
bug-fix tests
Projects
None yet
Milestone
No milestone
3 participants
@smithfarm @dzafman @jdurgin