misc: SCA and Coverity Fixes #13208
Merged
misc: SCA and Coverity Fixes #13208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
approved these changes
Feb 1, 2017
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Do not call c_str() if the parameter is already of type string. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
…tors Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix for: CID 1398896: Resource leak (RESOURCE_LEAK) overwrite_var: Overwriting fe in fe = new RGWLoadGenFrontend(env, config) leaks the storage that fe points to. Do not check again and again for framework if there is already a match, make use of if/else. This should also fix the RESOURCE_LEAK warning. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
ID 1398895 (#1 of 1): Resource leak (RESOURCE_LEAK) leaked_storage: Variable config going out of scope leaks the storage it points to. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
CID 1395784 (#2-1 of 2): Resource leak (RESOURCE_LEAK) leaked_storage: Variable state going out of scope leaks the storage it points to. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix for: CID 1395468 (#1 of 1): Self assignment (NO_EFFECT) self_assign: Assigning bh->last_write to itself has no effect. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Some variables have been already free'd by calling release(), no need to call delete() again on them. CID 1396200 (#1 of 1): Double free (USE_AFTER_FREE) double_free: Calling operator delete frees pointer getxattr_completion which has already been freed. CID 1396206 (#1 of 1): Double free (USE_AFTER_FREE) double_free: Calling operator delete frees pointer getxattr_completion which has already been freed. CID 1396214 (#1 of 1): Double free (USE_AFTER_FREE) double_free: Calling operator delete frees pointer stat_completion which has already been freed. CID 1396218 (#1 of 1): Double free (USE_AFTER_FREE) double_free: Calling operator delete frees pointer stat_completion which has already been freed. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
liewegas
force-pushed
the
wip-dalgaaf-sca-20170131
branch
from
1830b46
to
ce5493c
Compare
|
http://pulpito.ceph.com/sage-2017-02-08_18:25:33-rados-wip-sage-testing---basic-smithi/ looks ok. pushed rebased branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.