msg/simple: fix missing unlock when already bind #13267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haomai Wang <haomai@xsky.com>
|
caused by #12901 |
|
hi, @yuyuyu101
|
liuchang0812
suggested changes
Feb 6, 2017
src/msg/simple/SimpleMessenger.cc
Outdated
| @@ -312,6 +312,7 @@ int SimpleMessenger::client_bind(const entity_addr_t &bind_addr) | |||
| lock.Lock(); | |||
| if (did_bind) { | |||
| assert(my_inst.addr == bind_addr); | |||
| lock.Unlock(); | |||
There was a problem hiding this comment.
AsyncMessager::client_bind also need this patch.
|
thanks, done |
tchaikov
reviewed
Feb 6, 2017
src/msg/async/AsyncMessenger.cc
Outdated
| @@ -396,6 +396,7 @@ int AsyncMessenger::client_bind(const entity_addr_t &bind_addr) | |||
| lock.Lock(); | |||
| if (did_bind) { | |||
| assert(my_inst.addr == bind_addr); | |||
| lock.Unlock(); | |||
There was a problem hiding this comment.
nit, better off using Mutex::Locker. or instead switch to std::mutex, and use std::lock_guard instead.
Signed-off-by: Haomai Wang <haomai@xsky.com>
yuyuyu101
force-pushed
the
wip-fix-lock
branch
from
7a05e7a
to
067d569
Compare
|
@tchaikov done |
tchaikov
approved these changes
Feb 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Haomai Wang haomai@xsky.com